Make easier for users to point to their geonetwork application #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new user executes the suggested command `./gemet-to-simpleskos.sh en fr de nl it` without updating the value of `GEONETWORK_HOME` inside `gemet-to-simpleskos.sh` it will fail with a confusing error: ```bash Creating thesaurus ... Error: Could not find or load main class net.sf.saxon.Transform ``` This happens because the CLASSPATH for the java call should contain `$GEONETWORK_HOME/WEB-INF/lib/saxon-9.1.0.8b-patch.jar` and the `GEONETWORK_HOME` is set inside `gemet-to-simpleskos.sh` to a default path. If geonetwork is not present at that path the script will fail. A better approach is make the user set the `GEONETWORK_HOME` variable before calling the script. I also added a check to warn the user if the script could not locate the saxon jar. In this case it will print an error message and exit with an error code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent some time wondering why this script didn't work for me and then I realized the
GEONETWORK_HOMEwas set insidegemet-to-simpleskos.shto a path different to my geonetwork installation.If a new user executes the suggested command
./gemet-to-simpleskos.sh en fr de nl itwithout updating the value ofGEONETWORK_HOMEinsidegemet-to-simpleskos.shit will fail with a confusing error:This happens because the CLASSPATH for the java call should contain
$GEONETWORK_HOME/WEB-INF/lib/saxon-9.1.0.8b-patch.jarand theGEONETWORK_HOMEis set insidegemet-to-simpleskos.shto a default path. If geonetwork is not present at that path the script will fail.A better approach is make the user set the
GEONETWORK_HOMEvariable before calling the script.I also added a check to warn the user if the script could not locate the saxon jar. In this case it will print an error message and exit with an error code.