Use callback instead of reusing saved element

Re-query for the dialog element instead of reusing the prior element as suggested in testing-library/dom-testing-library#1204 (comment)
georgetown-cset · Oct 20, 2023 · 9cfb63c · 9cfb63c
1 parent 3ea3423
commit 9cfb63c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/web/gui-v2/src/components/ListView.test.js b/web/gui-v2/src/components/ListView.test.js
@@ -54,7 +54,7 @@ describe("ListView", () => {
       await user.click(removedCheckbox);
       expect(removedCheckbox.checked).toEqual(false);
       await user.click(getByRole(dialog, 'button', { name: 'Apply' }));
-      await waitForElementToBeRemoved(dialog);
+      await waitForElementToBeRemoved(() => screen.getByRole('dialog'));
       expect(screen.queryByRole('heading', { name: 'Add/remove columns'})).not.toBeInTheDocument();
 
       // Verify that the changes took effect