Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo group membership data representation #148

Closed
brianlove opened this issue Oct 16, 2023 · 1 comment · Fixed by #149
Closed

Redo group membership data representation #148

brianlove opened this issue Oct 16, 2023 · 1 comment · Fixed by #149
Assignees
@jmelot
Labels
data Issues relating to the underlying data, not the interface
Milestone
PARAT v2

Comments

@brianlove
Copy link
Contributor

Replace company.in_sandp_500 and company.in_fortune_global_500 with company.groups.sp500 and company.groups.global500.

Note: my assumption is that “global500” is sufficiently unique to distinguish the Fortune Global 500, but if it’s not this could be fortuneGlobal500 instead (but that’s starting to get longer than I’d prefer).
@brianlove brianlove added the data Issues relating to the underlying data, not the interface label Oct 16, 2023
@brianlove brianlove added this to the PARAT v2 milestone Oct 16, 2023
jmelot added a commit that referenced this issue Oct 17, 2023
@jmelot
Update group representation
478b230 
Closes #148
@jmelot jmelot mentioned this issue Oct 17, 2023
Merged
@jmelot jmelot linked a pull request Oct 17, 2023 that will close this issue
Update data schema #149
Merged
@jmelot
Copy link
Member

jmelot commented Oct 20, 2023

Closed via #149

@jmelot jmelot closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmelot jmelot

Labels
data Issues relating to the underlying data, not the interface
Projects
None yet
Milestone
PARAT v2
Development

Successfully merging a pull request may close this issue.

Update data schema georgetown-cset/parat
2 participants
@jmelot @brianlove