Update data schema #149
Merged
Update data schema #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #18
|
No need for rebasing 👍 |
JavaScript CoverageSummary
Modified Files • (63%)
|
This was
linked to
issues
Oct 17, 2023
Closed
…splayed in, and only populate for top 5 in a category Closes #147
This was
linked to
issues
Oct 17, 2023
Update the GUI to take into account updates to the data schema. Changes to the group selection interface will come in a later PR.
brianlove
approved these changes
Oct 18, 2023
web/tests/test_retrieve_data.py
Outdated
| @@ -170,6 +167,7 @@ def run_clean_row_test(self, company): | |||
| with open(os.path.join(self.DATA_DIR, f"{company}_output.json")) as f: | |||
| expected_output = json.load(f) | |||
| output = clean_row(input_data, False, {}, market_key_to_link) | |||
| print(json.dumps(output)) | |||
There was a problem hiding this comment.
Is this print() still needed?
Increase test timeout to hopefully resolve issue where `waitForElementToBeRemoved` times out: testing-library/dom-testing-library#1204
…ta-updates Update GUI to accomodate data updates
This was referenced Oct 20, 2023
Closed
This was referenced Oct 20, 2023
Add fields to articles and patents data indicating in which tables the data should be displayed
#147
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
Closes #134 - Brian, some edits needed on your end in the patent tables in the detail view
Closes #138 (except stuff like adding new metrics that is tracked in other issues)
Closes #139
Closes #147
Closes #148
An opening salvo, let's discuss during our 1-1