Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework bifurcated group and company selector; eliminate “edit custom group” dialog #94

Closed
za158 opened this issue Sep 13, 2023 · 1 comment
Closed

Rework bifurcated group and company selector; eliminate “edit custom group” dialog #94

za158 opened this issue Sep 13, 2023 · 1 comment
Assignees
@brianlove
Labels
high priority view:list Issues specific to the list view of PARAT
Milestone
PARAT v2

Comments

@za158
Copy link
Member

za158 commented Sep 13, 2023

As discussed. There should not be a separate group selector or "edit custom group" dialog. Groups and individual companies should be selectable from the dropdown in the column currently titled "companies," similar to the countries menu in CAT.
@za158 za158 mentioned this issue Sep 13, 2023
Closed
@brianlove brianlove self-assigned this Sep 19, 2023
@brianlove brianlove added this to the Zach's comments on PARAT v2 milestone Sep 19, 2023
@brianlove brianlove added high priority view:list Issues specific to the list view of PARAT labels Sep 29, 2023
@jmelot jmelot modified the milestones: Zach's comments on PARAT v2, PARAT v2 Oct 10, 2023
brianlove added a commit that referenced this issue Oct 20, 2023
@brianlove
Update tests
aba56f5 
Updated tests to reflect the new selection of initial columns.

Commented out the group selector test since that interface will be
changing substantially in #94 and was impacted by the UI Components
update.
@brianlove brianlove mentioned this issue Oct 24, 2023
Merged
jmelot pushed a commit that referenced this issue Oct 30, 2023
@brianlove @jmelot
Update tests
c5d1c3b 
Updated tests to reflect the new selection of initial columns.

Commented out the group selector test since that interface will be
changing substantially in #94 and was impacted by the UI Components
update.
@brianlove
Copy link
Contributor

Closed by #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianlove brianlove

Labels
high priority view:list Issues specific to the list view of PARAT
Projects
None yet
Milestone
PARAT v2
Development

No branches or pull requests
3 participants
@jmelot @brianlove @za158