Rework group selection interface #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need for rebasing 👍 |
jmelot
force-pushed
the
92-adjust-available-columns
branch
from
a6d8b4a to
2b9372f
Compare
brianlove
force-pushed
the
92-adjust-available-columns
branch
3 times, most recently
from
993c151 to
5a863d5
Compare
Merged
Add company groups to the compnay name dropdown. Note: the old group selection interface is still present for the time being (and the group selection test fails)
Updated test coverage for groups selection to accomodate the new interface. Added tests checking that rows are filtered as expected.
brianlove
force-pushed
the
94-rework-group-selection-interface
branch
from
de09319 to
5556c6f
Compare
jmelot
reviewed
Oct 31, 2023
Add and configure an Emotion cache to turn off the "potentially unsafe" error messages that show up even though they're not applicable.
JavaScript CoverageSummary
Modified Files • (64%)
|
|
Summary footer is tracked in @jmelot - Other than those separate issues, the tests are (finally) passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the group selection interface to be within the 'Name' column's dropdown instead of a separate modal. Update tests accordingly, including adding tests to ensure that filtering functions are working.
Closes #94