Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise company metadata table and add dialog with more data #129

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

brianlove
Copy link
Contributor

@brianlove brianlove commented Oct 4, 2023

Update the fields displayed in the detail view's metadata table. Add a dialog box to display additional fields.

Closes #81

Pending

@brianlove brianlove requested a review from jmelot October 4, 2023 21:41
@brianlove brianlove self-assigned this Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

No need for rebasing 👍
behind_count is 0
ahead_count is 3

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 70%
70% (266/380) 57.05% (93/163) 72.3% (94/130)
Modified Files • (70%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files7057.0572.370.32 
components70.859.8571.8471.06 
   DetailViewIntro.jsx000013–94
   DetailViewMoreMetadataDialog.jsx00009–93
   TwoColumnTable.jsx00006–59

@brianlove brianlove mentioned this pull request Oct 9, 2023
4 tasks
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I have the outstanding data issues on my "for next sprint" list so I'll get to them then, I think we can close this out in the meantime

@jmelot
Copy link
Member

jmelot commented Oct 11, 2023

Oh one more thing, I do find that the right alignment looks a bit weird, but not too bad (I'm assuming left alignment looks worse). What do you think @za158

Screenshot 2023-10-11 at 10 35 12 AM

@za158
Copy link
Member

za158 commented Oct 11, 2023

Oh one more thing, I do find that the right alignment looks a bit weird, but not too bad (I'm assuming left alignment looks worse). What do you think @za158
Screenshot 2023-10-11 at 10 35 12 AM

I think it's ok as is

@brianlove brianlove force-pushed the 81-more-company-details branch from 243d78c to 7e48a7b Compare October 13, 2023 01:36
@brianlove brianlove merged commit db19ac9 into version2 Oct 13, 2023
@brianlove brianlove deleted the 81-more-company-details branch October 13, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants