-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise company metadata table and add dialog with more data #129
Conversation
No need for rebasing 👍 |
JavaScript CoverageSummary
Modified Files • (70%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! I have the outstanding data issues on my "for next sprint" list so I'll get to them then, I think we can close this out in the meantime
Oh one more thing, I do find that the right alignment looks a bit weird, but not too bad (I'm assuming left alignment looks worse). What do you think @za158 |
I think it's ok as is |
If a value isn't available for a metadata table, display "None found"
243d78c
to
7e48a7b
Compare
Update the fields displayed in the detail view's metadata table. Add a dialog box to display additional fields.
Closes #81
Pending
data.full_market_links
are currently raw HTML objects instead of just the plain URLs (see Remove HTML markup from data files #18)