Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update total calculation to only include displayed yearly counts #130

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update total calculation to only include displayed yearly counts #130

merged 1 commit into from
Oct 10, 2023

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Oct 5, 2023

This updates the totals so they only cover the years we display in the UI (see discussion here: #88)

@jmelot jmelot requested a review from brianlove October 5, 2023 12:54
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

No need for rebasing 👍
behind_count is 0
ahead_count is 1

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 73%
 73.27% (266/363) 62.41% (93/149) 77.68% (94/121)
Modified Files • (73%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files73.2762.4177.6873.77 
static_data87.510010087.5 
   data.js100100100100 

@jmelot jmelot mentioned this pull request Oct 5, 2023
Closed
brianlove
brianlove approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@brianlove brianlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianlove brianlove merged commit afef37b into version2 Oct 10, 2023
@brianlove brianlove deleted the ensure-yearly-counts-add-up branch October 10, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlove brianlove brianlove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmelot @brianlove