Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open detail pages in new tabs #152

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Open detail pages in new tabs #152

merged 1 commit into from
Oct 20, 2023

Conversation

brianlove
Copy link
Contributor

Closes #104

@brianlove brianlove requested a review from jmelot October 19, 2023 14:50
@brianlove brianlove self-assigned this Oct 19, 2023
@github-actions
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

@github-actions
Copy link

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 63%
 63.47% (285/449) 57.55% (99/172) 67.33% (101/150)
Modified Files • (63%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files63.4757.5567.3363.4 
static_data93.7510010093.75 
   table_columns.js100100100100 

@jmelot jmelot force-pushed the 104-launch-detail-view-in-new-tab branch from cadbcdd to 8ceb53d Compare October 20, 2023 12:28
jmelot
jmelot approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit 0f7c8d9 into version2 Oct 20, 2023
3 of 4 checks passed
@jmelot jmelot deleted the 104-launch-detail-view-in-new-tab branch October 20, 2023 12:28
@brianlove brianlove mentioned this pull request Oct 20, 2023
Closed
@brianlove brianlove mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmelot jmelot jmelot approved these changes

Assignees

@brianlove brianlove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianlove @jmelot