-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rows to list view for selected groups #183
Conversation
No need for rebasing 👍 |
JavaScript CoverageSummary
Modified Files • (67%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the "Viewing X of Y companies" at the top left, I'm displaying only the number of companies, not groups. The number in the pagination controls in the lower right is the total number of rows (companies + groups). |
@za158 do you have an opinion here? The only thing that occurred to me was changing the word "companies" to "results" in "viewing 502 of 1670 companies", and then including the sum of the number of companies and company groups in that text |
If feasible, I would prefer to put the word "rows" after 503 in that example image. We will need to change the heading of the first column to something other than "Company" if groups are selected there, but we can figure that out later. |
Adding "rows" after "503" will require adding support for TablePagination's |
@za158 Adding the pagination controls does add a mention of rows to that part of the table, but in a slightly different spot. Do you think this screenshot is sufficient, or do you still want it to say "1-10 of 503 rows"? |
This seems fine |
67d2ba8
to
bb3cf7d
Compare
Two more small things: 1.) If you click on the name of the average row, you are directed to an empty company page - we should just not link to anything |
Add rows to the list view displaying the average data for each selected group (S&P 500, Fortune 500, etc). Groups currently have placeholder data, but this will be resolved in #123. Styling to distinguish group rows from company rows will require changes to the UI Components `<Table>`, which is tracked in georgetown-cset/eto-ui-components#341 Closes #101
bb3cf7d
to
452d610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Add rows to the list view displaying the average data for each selected group (S&P 500, Fortune 500, etc). Groups currently have placeholder data, but this will be resolved in #123.
Styling to distinguish group rows from company rows will require changes to the UI Components
<Table>
, which is tracked in https://github.com/georgetown-cset/eto-ui-components/issues/341Closes #101