Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save sort state as URL parameter #208

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Save sort state as URL parameter #208

merged 1 commit into from
Feb 2, 2024

Conversation

brianlove
Copy link
Contributor

Add a URL parameter (sort) to control the table's sort status, and update the parameter upon the table's sort changing.

Closes #24

@brianlove brianlove requested a review from jmelot February 1, 2024 21:57
@brianlove brianlove self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

github-actions bot commented Feb 1, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.64% (368/544) 59.85% (170/284) 67.56% (125/185)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.6459.8567.5667.25 
components64.362.4461.963.73 
   ListViewTable.jsx93.9381.1198.2793.98290–291, 296–299, 391, 436, 576, 630–631, 634, 653, 673–678

Add a URL parameter (`sort`) to control the table's sort status, and
update the parameter upon the table's sort changing.

Closes #24
@jmelot jmelot force-pushed the 24-save-sort-state branch from eba4632 to 069203f Compare February 2, 2024 17:07
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !

@jmelot jmelot merged commit 0e5d27c into version2 Feb 2, 2024
4 checks passed
@jmelot jmelot deleted the 24-save-sort-state branch February 2, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants