Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the full market links #216

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add the full market links #216

merged 2 commits into from
Feb 13, 2024

Conversation

brianlove
Copy link
Contributor

Closes #214

@brianlove brianlove requested a review from jmelot February 12, 2024 15:37
@brianlove brianlove self-assigned this Feb 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

No need for rebasing 👍
behind_count is 0
ahead_count is 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
 67.87% (374/551) 59.58% (174/292) 67.55% (127/188)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.8759.5867.5567.5 
components64.462.1162.0163.84 
   DetailViewMoreMetadataDialog.jsx00009–103

jmelot
jmelot reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me! My only comment is that I wonder if it would make sense to comma-separate these to prevent the dialog from getting as tall in the (probably rare) cases where we have a bunch of these. I'm fine if you want to keep it as-is, though

Screenshot 2024-02-13 at 12 03 01 PM

@brianlove
Separate market links with commas, not new lines
ed0f0ab 
Some companies (like Microsoft) have a lot of market links, so use
commas instead to separate them instead of having each be on its own
line.
@brianlove brianlove merged commit 62f86f7 into version2 Feb 13, 2024
4 checks passed
@brianlove brianlove deleted the 214-address-full-market-links branch February 13, 2024 21:58
@brianlove brianlove mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmelot jmelot jmelot left review comments

Assignees

@brianlove brianlove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianlove @jmelot