Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips next to column entries #319

Merged
merged 2 commits into from
May 7, 2024

Conversation

brianlove
Copy link
Contributor

@brianlove brianlove commented May 6, 2024

Add tooltips to each (selectable) column header and in the add/remove column dialog. Tooltip text is TBD. Widen columns to make header text and tooltips fit better.

Closes #267, closes #209

brianlove added 2 commits May 6, 2024 16:21
Add tooltips to each (selectable) column header and in the add/remove
column dialog.  Tooltip text is TBD.

Closes #267
Increase the default width of table columns to ensure that the column
tooltips can be displayed without wrapping onto a new line by themselves.
@brianlove brianlove requested a review from jmelot May 6, 2024 20:31
@brianlove brianlove self-assigned this May 6, 2024
Copy link

github-actions bot commented May 6, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 2

Copy link

github-actions bot commented May 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
572 370 65% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 8f3cce5 by action🐍

Copy link

github-actions bot commented May 6, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
68.1% (395/580) 58.02% (188/324) 68.22% (131/192)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files68.158.0268.2267.77 
components64.2259.1462.5963.76 
   AddRemoveColumnDialog.jsx91.667583.3391.379, 99
static_data72.584876.6669.64 
   table_columns.js71.664876.6668.51196–229, 246–248, 276, 322–348, 365–367

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit e127d53 into master May 7, 2024
5 checks passed
@jmelot jmelot deleted the 267-add-tooltips-in-column-selection-dialog branch May 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants