Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make additional columns sortable and fix slider font #356

Merged
merged 1 commit into from
May 22, 2024

Conversation

brianlove
Copy link
Contributor

Make the Country, Region, Stage, and Sector columns sortable (closes #274)

Fix the font in the floating labels for the sliders (closes #327)

@brianlove brianlove requested a review from jmelot May 20, 2024 19:22
@brianlove brianlove self-assigned this May 20, 2024
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

github-actions bot commented May 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
607 395 65% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 022231e by action🐍

Copy link

github-actions bot commented May 20, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.36% (388/576) 55.62% (188/338) 67.93% (125/184)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.3655.6267.9367.09 
components63.9256.6562.5963.46 
   HeaderSlider.jsx88.2383.338086.6666–67
   ListViewTable.jsx91.0173.2598.3690.9285, 368–369, 374–377, 486, 531, 691, 712–715, 731–732, 756–757, 760, 778–781, 801–806
static_data67.8545.4577.2765.38 
   table_columns.js66.6645.4577.2764222–575, 593

Make the Country, Region, Stage, and Sector columns sortable (closes #274)

Fix the font in the floating labels for the sliders (closes #327)
@jmelot jmelot force-pushed the 274-327-more-sort-options-and-slider-font branch from 1d69664 to 022231e Compare May 22, 2024 20:20
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit 1dbdf4e into master May 22, 2024
5 checks passed
@jmelot jmelot deleted the 274-327-more-sort-options-and-slider-font branch May 22, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slider popup text is off spec consider adding sort option to other categories too
2 participants