Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detail growth #373

Merged
merged 2 commits into from
May 30, 2024
Merged

Update detail growth #373

merged 2 commits into from
May 30, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented May 28, 2024 •
edited
Loading

Closes #254

@jmelot jmelot requested a review from brianlove May 28, 2024 22:35
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Needs rebasing ‼️
behind_count is 2
ahead_count is 2

@jmelot jmelot changed the base branch from master to update-ids May 28, 2024 22:36
@jmelot jmelot force-pushed the 254-update-detail-growth branch from e7e6af8 to e417567 Compare May 29, 2024 15:10
@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
590 417 71% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
web/scripts/retrieve_data.py 65% 🟢
TOTAL 65% 🟢

updated for commit: e417567 by action🐍

@github-actions GitHub Actions
Copy link

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
 67.46% (396/587) 53.18% (192/361) 67.74% (126/186)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.4653.1867.7467.21 
components64.4453.0662.1264 
   DetailViewPatents.jsx000015–153
   DetailViewPublications.jsx000015–142
static_data65.5155.1777.2762.96 
   data.js100100100100 

Base automatically changed from update-ids to master May 29, 2024 16:43
brianlove
brianlove approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@brianlove brianlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianlove brianlove merged commit 6a2b9f8 into master May 30, 2024
5 checks passed
@brianlove brianlove deleted the 254-update-detail-growth branch May 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlove brianlove brianlove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NaN% in detail view table
2 participants
@jmelot @brianlove