Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust various smaller UI elements #380

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

brianlove
Copy link
Contributor

brianlove added 2 commits May 31, 2024 10:46
* Added a tooltip to the detail view's growth columns (closes #257).
* Remove group-related entries from the metadata modal (closes #334).
* Displayed "AI jobs" column by default instead of "TT1 jobs" (closes #366).
* Remove the ticker row from the condensed metadata table (closes #367).
@brianlove brianlove requested a review from jmelot May 31, 2024 15:05
@brianlove brianlove self-assigned this May 31, 2024
Copy link

github-actions bot commented May 31, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 3

Copy link

github-actions bot commented May 31, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
594 423 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 43d6426 by action🐍

Copy link

github-actions bot commented May 31, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.91% (398/586) 55.94% (207/370) 68.1% (126/185)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.9155.9468.167.69 
components64.7556.6462.5964.33 
   DetailViewIntro.jsx000013–91
   DetailViewMoreMetadataDialog.jsx00009–105
   DetailViewPatents.jsx000016–162
   DetailViewPublications.jsx000016–151
static_data67.8555.1777.2765.38 
   table_columns.js66.6655.1777.2764223–350, 591–592
   tooltips.js100100100100 

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, lots of issue closing! One small thing, I think this may have removed the tickers from the metadata table altogether rather than just from the condensed table

Restore the stock ticker rows as part of the detailed metadata modal
(instead of the summary table that it was originally part of).
@brianlove brianlove requested a review from jmelot June 3, 2024 17:46
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit 306b42a into master Jun 3, 2024
5 checks passed
@jmelot jmelot deleted the 257-334-366-367-various-smaller-issues branch June 3, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants