-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group options in patent trends chart's dropdown #387
Conversation
No need for rebasing 👍 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JavaScript CoverageSummary
Modified Files • (67%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will note that this does not fully resolve #357 - e.g. see Microsoft in Robotics, Document management and publishing, and Military. These are all fairly rare (e.g. Robotics only occurs in 28 companies, Document Management and Publishing occurs in 16, and Military occurs in 12) (fyi @za158)
Do you want to handle subfields without patents in the UI, or do you want me to filter these out on the backend? If the latter, just leave that issue open
I don't think the Microsoft in [Robotics, Document Management & Publishing, Military] cases you mentioned are consistent with #357. In that issue, the problem is that there are no underlying data ( We may want to handle low-data categories like these differently, but I think that's an analytic question to resolve, not a technical issue with the current state of the app. |
Ah ok got it, I misread that issue. I'll ping Zach about what to do about subfields without patent data |
Organize the various options in the dropdown menu controlling the patent trends chart to group related options together and remove other (non-charted) options.
Closes #337, closes #357