Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rollups; fix name mapping #393

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Remove rollups; fix name mapping #393

merged 2 commits into from
Jun 4, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Jun 3, 2024

Closes #375
Closes #353

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

No need for rebasing 👍
behind_count is 0
ahead_count is 2

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
594 423 71% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
web/scripts/retrieve_data.py 66% 🟢
web/tests/test_retrieve_data.py 100% 🟢
TOTAL 83% 🟢

updated for commit: f7fe3bc by action🐍

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
 67.72% (405/598) 55.18% (213/386) 68.27% (127/186)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.7255.1868.2767.49 
static_data67.8555.1777.2765.38 
   data.js100100100100 

@jmelot jmelot force-pushed the 375-no-roll-ups branch from 9fa9be9 to 7a0cb2f Compare June 3, 2024 19:04
@jmelot jmelot requested a review from brianlove June 3, 2024 19:36
brianlove
brianlove approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@brianlove brianlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianlove brianlove merged commit 7dc05e9 into master Jun 4, 2024
5 checks passed
@brianlove brianlove deleted the 375-no-roll-ups branch June 4, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlove brianlove brianlove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit orgs to not roll up Unexpected capitalization of the 'S' in "Macy's"
2 participants
@jmelot @brianlove