Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show human-readable name for filtered groups #394

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

brianlove
Copy link
Contributor

Improve readability of active filter tooltip when a group has been selected.

Closes #329

@brianlove brianlove requested a review from jmelot June 3, 2024 18:40
@brianlove brianlove self-assigned this Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

github-actions bot commented Jun 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
594 423 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 4bdbb42 by action🐍

Copy link

github-actions bot commented Jun 3, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
68.18% (405/594) 56.34% (213/378) 68.27% (127/186)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files68.1856.3468.2767.97 
components65.1657.1462.8764.77 
   ListViewTable.jsx90.973.8898.3890.8286, 369–370, 375–378, 487, 532, 692, 713–716, 732–733, 757–758, 761, 779–782, 806, 820–825

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Improve readability of active filter tooltip when a group has been
selected.

Closes #329
@jmelot jmelot force-pushed the 329-format-group-in-active-filters-tooltip branch from 3fd5d37 to 4bdbb42 Compare June 3, 2024 20:13
@jmelot jmelot merged commit df76332 into master Jun 3, 2024
4 checks passed
@jmelot jmelot deleted the 329-format-group-in-active-filters-tooltip branch June 3, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GROUP: sp500
2 participants