Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and consolidate tooltips #396

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

brianlove
Copy link
Contributor

Add tooltips to relevant portions of the detail view page (closes #360). Adjust patent growth tooltip structure to match newly-added tooltips. Consolidate column tooltip definitions into a single file (closes #377).

@brianlove brianlove requested a review from jmelot June 3, 2024 20:23
@brianlove brianlove self-assigned this Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 2

Copy link

github-actions bot commented Jun 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
595 424 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: e7cc55e by action🐍

Copy link

github-actions bot commented Jun 3, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.66% (406/600) 54.61% (213/390) 68.44% (128/187)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.6654.6168.4467.43 
components64.4454.962.8764.01 
   DetailViewPatents.jsx000016–227
   DetailViewPublications.jsx000016–153
   DetailViewWorkforce.jsx000013–53
   SectionHeading.jsx0100004–20
   StatBox.jsx0100008–66
   StatGrid.jsx00006–69
   TrendsChart.jsx00009–67
static_data68.4255.1778.2666.03 
   table_columns.js67.2755.1778.2664.7215–331, 540–541
   tooltips.js100100100100 
util83.6952.7284.3786.74 
   plotly-helpers.js85.1838.0910085.1893, 102–105

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will say that these tooltips look a bit odd way over on the right

Screenshot 2024-06-05 at 11 58 47 AM

web/gui-v2/src/util/plotly-helpers.js Show resolved Hide resolved
brianlove added 2 commits June 6, 2024 13:35
Add tooltips to relevant portions of the detail view page (closes #360).
Adjust patent growth tooltip structure to match newly-added tooltips.
Consolidate column tooltip definitions into a single file (closes #377).
Tweak the styles of section headings to fix bugs with how tooltips are handled.
@brianlove brianlove force-pushed the 360-377-add-and-consolidate-tooltips branch from 7c0e0da to e7cc55e Compare June 6, 2024 17:35
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit 8bd00d1 into master Jun 6, 2024
5 checks passed
@jmelot jmelot deleted the 360-377-add-and-consolidate-tooltips branch June 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate tooltip definition locations Add tooltips and alert to detail view
2 participants