Fix incorrect slugification of company names #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need for rebasing 👍 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
jmelot
approved these changes
Jun 5, 2024
Ignore slashes and periods when slugifying company names. Closes #365
Standardize the slugification process across page generation (via gatsby-config.js) and link generation (src/util/index.js), using the @sindresorhus/slugify package used internally by Gatsby. Switch how names like "Jd.Com" are slugified to be consistent with sindresorhus's approach.
brianlove
force-pushed
the
365-fix-periods-in-slug
branch
from
1aaebbc to
b0305e9
Compare
|
@jmelot Found and fixed the issue - Gatsby used a different slugification process, so there wasn't agreement between the pages that were actually generated and the links that were generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore slashes and periods when slugifying company names.
Closes #365