Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize yearly count column names #398

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Standardize yearly count column names #398

merged 2 commits into from
Jun 6, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Jun 5, 2024

Closes #348

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

No need for rebasing 👍
behind_count is 0
ahead_count is 2

@jmelot jmelot force-pushed the 348-normalize-yearly-count-column-names branch from a80dd4f to 079ff0e Compare June 5, 2024 14:29
@jmelot jmelot force-pushed the 348-normalize-yearly-count-column-names branch from 079ff0e to c56b2d9 Compare June 5, 2024 15:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
595 424 71% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
web/scripts/retrieve_data.py 66% 🟢
TOTAL 66% 🟢

updated for commit: c56b2d9 by action🐍

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
 67.72% (405/598) 55.18% (213/386) 68.27% (127/186)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.7255.1868.2767.49 
static_data67.8555.1777.2765.38 
   data.js100100100100 

@jmelot jmelot changed the title Untested first pass at updating all the yearly count column names Standardize yearly count column names Jun 5, 2024
@jmelot jmelot requested a review from rggelles June 5, 2024 16:14
@jmelot jmelot marked this pull request as ready for review June 5, 2024 16:15
rggelles
rggelles approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@rggelles rggelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rggelles rggelles merged commit a279b8d into master Jun 6, 2024
5 checks passed
@rggelles rggelles deleted the 348-normalize-yearly-count-column-names branch June 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rggelles rggelles rggelles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalize column names for all yearly counts
2 participants
@jmelot @rggelles