Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out parent organizations with no parat identifier #400

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Jun 5, 2024

Some parent organizations were added to Airtable without a CSET identifier. This filters them out so the downstream code that rolls up organizations into their parents doesn't use these parentage relationships. (fyi @za158)

Closes #376

Copy link

github-actions bot commented Jun 5, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 2

@jmelot jmelot requested a review from brianlove June 5, 2024 21:30
@jmelot
Copy link
Member Author

jmelot commented Jun 6, 2024

Ugh hang on I see (a) the tests failed and (b) there's a merge conflict in the data... I'm going to merge your PRs, rebase, and fix the tests now

@jmelot jmelot force-pushed the 376-null-org-names branch from 2a86caa to 84783fd Compare June 7, 2024 14:27
Copy link

github-actions bot commented Jun 7, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
595 424 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 84783fd by action🐍

Copy link

github-actions bot commented Jun 7, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.44% (404/599) 54.35% (212/390) 68.44% (128/187)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.4454.3568.4467.19 
static_data68.4255.1778.2666.03 
   data.js100100100100 

Copy link
Contributor

@brianlove brianlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianlove brianlove merged commit 7607b3f into master Jun 7, 2024
5 checks passed
@brianlove brianlove deleted the 376-null-org-names branch June 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate orgs with null names
2 participants