Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip and adjust workforce section text #416

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

brianlove
Copy link
Contributor

Repeat the AI conference pubs tooltip in the StatBox (closes #412). Adjust the handling of the workforce section's text to allow different text for each stat (closes #408).

@brianlove brianlove requested a review from jmelot June 12, 2024 15:33
@brianlove brianlove self-assigned this Jun 12, 2024
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

github-actions bot commented Jun 12, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
597 426 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 62bc198 by action🐍

Copy link

github-actions bot commented Jun 12, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 68%
68.42% (416/608) 56.2% (222/395) 70.15% (134/191)
Modified Files • (68%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files68.4256.270.1568.23 
components64.255.5264.9263.78 
   DetailViewPublications.jsx000016–153
   DetailViewWorkforce.jsx000013–67

Repeat the AI conference pubs tooltip in the StatBox (closes #412).
Adjust the handling of the workforce section's text to allow different
text for each stat (closes #408).
@jmelot jmelot force-pushed the 408-412-adjust-text-and-tooltips branch from 08712d6 to 62bc198 Compare June 14, 2024 13:49
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit 602befc into master Jun 14, 2024
4 of 5 checks passed
@jmelot jmelot deleted the 408-412-adjust-text-and-tooltips branch June 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

repeat a tooltip edits to workforce detail text
2 participants