Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN and NUMBER in detail view pages #447

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

brianlove
Copy link
Contributor

Say "N/A" instead of "NaN%", and add the actual number in the workforce section.

Closes #433, closes #439

@brianlove brianlove requested a review from jmelot June 21, 2024 13:13
@brianlove brianlove self-assigned this Jun 21, 2024
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
597 426 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: afca3f1 by action🐍

Copy link

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.91% (417/614) 55.88% (223/399) 69.79% (134/192)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.9155.8869.7967.7 
components63.3854.8264.4462.92 
   DetailViewPublications.jsx000016–154
   DetailViewWorkforce.jsx000013–67

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit de49731 into master Jun 21, 2024
5 checks passed
@jmelot jmelot deleted the 433-439-fix-NaN-and-NUMBER branch June 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"NUMBER" NaN%
2 participants