-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework window sizes to resolve squished pages #448
Conversation
Rework window size detection to prevent desktop pages from loading in a "squished" state before adjusting, at the expense of mobile pages briefly showing the table of contents before it is hidden. Closes #240. Fix several cases of keys not being present in loops. Updated browserslist DB.
No need for rebasing 👍 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JavaScript CoverageSummary
Modified Files • (67%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
We'll see what Zach thinks when it's on the dev site, but I think the mobile version of the weirdness is less noticeable/problematic
Rework window size detection to prevent desktop pages from loading in a "squished" state before adjusting, at the expense of mobile pages briefly showing the table of contents before it is hidden. Closes #240.
Fix several cases of keys not being present in loops. Updated browserslist DB.
@za158 @jmelot Video showing the TOC-on-mobile situation that results from this PR:
Screen.Recording.2024-06-21.at.9.49.34.AM.mov