Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework window sizes to resolve squished pages #448

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

brianlove
Copy link
Contributor

Rework window size detection to prevent desktop pages from loading in a "squished" state before adjusting, at the expense of mobile pages briefly showing the table of contents before it is hidden. Closes #240.

Fix several cases of keys not being present in loops. Updated browserslist DB.

@za158 @jmelot Video showing the TOC-on-mobile situation that results from this PR:

Screen.Recording.2024-06-21.at.9.49.34.AM.mov

Rework window size detection to prevent desktop pages from loading in
a "squished" state before adjusting, at the expense of mobile pages
briefly showing the table of contents before it is hidden.  Closes #240.

Fix several cases of keys not being present in loops.
Updated browserslist DB.
@brianlove brianlove requested a review from jmelot June 21, 2024 14:05
@brianlove brianlove self-assigned this Jun 21, 2024
Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 1

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
597 426 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 1eaba90 by action🐍

Copy link

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
68.07% (420/617) 55.88% (223/399) 69.94% (135/193)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files68.0755.8869.9467.86 
components63.5154.8564.4463.06 
   AddRemoveColumnDialog.jsx93.3387.587.593.1122, 142
util83.1552.6384.8486.04 
   useWindowSize.js93.755010093.3316

@za158
Copy link
Member

za158 commented Jun 21, 2024 via email

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

We'll see what Zach thinks when it's on the dev site, but I think the mobile version of the weirdness is less noticeable/problematic

@jmelot jmelot merged commit efa0e67 into master Jun 21, 2024
5 checks passed
@jmelot jmelot deleted the 240-detail-page-squished-briefly-on-load branch June 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detail views briefly have all the content squished to the left on desktop
3 participants