Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tt1 csv #449

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Add tt1 csv #449

merged 2 commits into from
Jun 22, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Jun 21, 2024

Closes #438

Rebecca I updated the column names from the ones in BQ to make them a little clearer to external people. Can you please check them and update them if the new names are misleading (I was sort of guessing at what some of these columns were)?

@jmelot jmelot requested a review from rggelles June 21, 2024 16:20
Copy link

github-actions bot commented Jun 21, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 2

Copy link

github-actions bot commented Jun 21, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
597 426 71% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fe748b6 by action🐍

Copy link

github-actions bot commented Jun 21, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 67%
67.96% (420/618) 55.61% (223/401) 69.94% (135/193)
Modified Files • (67%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files67.9655.6169.9467.75 
report-only-changed-files is enabled. No files were changed in this commit :)

Copy link
Member

@rggelles rggelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the only distinction is it's not exactly job title -- it's a job class grouping that encompasses a bunch of different job titles. If that distinct isn't important then this is fine. But besides that, looks good to me.

@jmelot
Copy link
Member Author

jmelot commented Jun 22, 2024

Thanks, makes sense, I updated the column name!

@jmelot jmelot merged commit cc7fac8 into master Jun 22, 2024
3 checks passed
@jmelot jmelot deleted the 483-add-tt1-csv branch June 22, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a certain BQ table publicly accessible
2 participants