Rework buttonbar label visibility based on viewport #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the visibility of the labels for the Reset, Download, and Column buttons based on the available space in the buttonbar. Download's label will hide first (still accessible to screen readers), followed by Add/Remove Columns, and finally Reset. If not enough space is available for the "Viewing X of Y..." text and/or buttons, they will wrap onto the next row of the buttonbar. Closes #464
|
No need for rebasing 👍 |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JavaScript CoverageSummary
|
jmelot
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the visibility of the labels for the Reset, Download, and Column buttons based on the available space in the buttonbar. Download's label will hide first (still accessible to screen readers), followed by Add/Remove Columns, and finally Reset. If not enough space is available for the "Viewing X of Y..." text and/or buttons, they will wrap onto the next row of the buttonbar.
Closes #464
Screen.Recording.2024-06-25.at.11.45.06.PM.mov