Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toleration for parat node pool #488

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Add toleration for parat node pool #488

merged 1 commit into from
Sep 12, 2024

Conversation

jmelot
Copy link
Member

@jmelot jmelot commented Aug 21, 2024

I'm working to prevent GKE from scheduling its own operations on more expensive node pools by adding taints to those pools, and tolerations to the relevant GKEStartPodOperators (see also https://cloud.google.com/kubernetes-engine/distributed-cloud/vmware/docs/how-to/node-taints)

@jmelot jmelot requested a review from rggelles August 21, 2024 13:56
Copy link

github-actions bot commented Aug 21, 2024

No need for rebasing 👍
behind_count is 1
ahead_count is 1

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
656 429 65% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 9caa9bc by action🐍

Copy link

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 68%
68.98% (456/661) 56.31% (232/412) 70.55% (139/197)
Modified Files • (68%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files68.9856.3170.5568.84 
report-only-changed-files is enabled. No files were changed in this commit :)

Base automatically changed from update-to-artifact-registry to master August 21, 2024 16:53
Copy link
Member

@rggelles rggelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very clever.

@rggelles rggelles merged commit 43215c0 into master Sep 12, 2024
5 checks passed
@rggelles rggelles deleted the add-gke-toleration branch September 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants