-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(climate): deprecate aux_heating feature #486
base: master
Are you sure you want to change the base?
Conversation
I can validate this does work, but I don't believe this should be removed: ClimateEntityFeature.SWING_MODE | \ My AC uses that feature (horizonal and vertical vent swings) and that can stay in with no issue. Thanks! |
Swing mode remains, I did only remove the |
Afaik current master was reported as broken in #420. So it would be great if this PR is merged together with that. But that's just my two cents! Thank you for your great (and more importantly, quick) work! |
I am new to HA and my current skill and knowledge level is very basic, but I am trying to learn. What do I need to do to update the integration? Please be gentle! |
Same Here. How to get this Update without manually editing Files? |
You don´t need to do it. This should be merged by October. Right now the integration is supposed to work the same way. |
Doesn't it make more sense to convert this into a switch and a sensor instead of simply removing the function? |
There is already a switch for that. midea_ac_lan/custom_components/midea_ac_lan/midea_devices.py Lines 328 to 332 in 7c5231c
|
I tried your fix and it's actually working, I still have a lot of deprecation warning :
|
#420 fixes those. |
# Conflicts: # custom_components/midea_ac_lan/climate.py
# Conflicts: # custom_components/midea_ac_lan/climate.py
Will try it. Do you know if the maintainer is still active to merge those PR ? |
i dunno |
as current repo is not active, just add comments in all PRs, forked new repo is : PR is welcome Thanks |
Removed deprecated feature aux_heating
Fixes: #483
Fixes: #484
Fixes: #487
Fixes: #488
Fixes: #490
Fixes: #492
Fixes: #495
Fixes: #496
Fixes: #498