Errors during docker build should make the DockerBuildTask fail

Closes #195
gesellix · Feb 7, 2022 · 60e6301 · 60e6301
1 parent 6815b28
commit 60e6301
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/plugin/src/main/java/de/gesellix/gradle/docker/tasks/DockerBuildTask.java b/plugin/src/main/java/de/gesellix/gradle/docker/tasks/DockerBuildTask.java
@@ -244,14 +244,26 @@ public void onFinished() {
         actualBuildContext);
     try {
       getLogger().debug("Waiting " + buildTimeout + " for the build to finish...");
-      buildFinished.await(buildTimeout.toMillis(), TimeUnit.MILLISECONDS);
+      boolean finished = buildFinished.await(buildTimeout.toMillis(), TimeUnit.MILLISECONDS);
+      if (!finished) {
+        getLogger().error("Build didn't finish before timeout of " + buildTimeout);
+        return null;
+      }
+
+      if (BuildInfoExtensionsKt.hasError(infos)) {
+        BuildInfo error = BuildInfoExtensionsKt.getError(infos);
+        getLogger().error("Build failed. {}", error != null ? error.getErrorDetail() : null);
+        return null;
+      }
+
+      ImageID imageId = BuildInfoExtensionsKt.getImageId(infos);
+      this.imageId = imageId == null ? null : imageId.getID();
+      return this.imageId;
     }
     catch (InterruptedException e) {
-      getLogger().error("Build didn't finish before timeout of " + buildTimeout, e);
+      getLogger().error("Build interrupted before timeout of " + buildTimeout, e);
+      return null;
     }
-    ImageID imageId = BuildInfoExtensionsKt.getImageId(infos);
-    this.imageId = imageId == null ? null : imageId.getID();
-    return this.imageId;
   }
 
   @Internal