feat: add possibility to delete orders

coordinator/migrations/2024-03-10-042249_add_delete_state_to_order/down.sql

@@ -0,0 +1,2 @@
+-- We need to do something, or the migration fails
+select 1;

coordinator/migrations/2024-03-10-042249_add_delete_state_to_order/up.sql

@@ -0,0 +1 @@
+ALTER TYPE "OrderState_Type" ADD VALUE IF NOT EXISTS 'Deleted';

coordinator/src/orderbook/db/custom_types.rs

@@ -102,6 +102,8 @@ pub(crate) enum OrderState {
     Failed,
     /// The order expired.
     Expired,
+    /// The order was manually deleted by the trader
+    Deleted,
 }
 
 impl QueryId for OrderStateType {
@@ -121,6 +123,7 @@ impl ToSql<OrderStateType, Pg> for OrderState {
             OrderState::Taken => out.write_all(b"Taken")?,
             OrderState::Failed => out.write_all(b"Failed")?,
             OrderState::Expired => out.write_all(b"Expired")?,
+            OrderState::Deleted => out.write_all(b"Deleted")?,
         }
         Ok(IsNull::No)
     }
@@ -134,6 +137,7 @@ impl FromSql<OrderStateType, Pg> for OrderState {
             b"Taken" => Ok(OrderState::Taken),
             b"Failed" => Ok(OrderState::Failed),
             b"Expired" => Ok(OrderState::Expired),
+            b"Deleted" => Ok(OrderState::Deleted),
             _ => Err("Unrecognized enum variant".into()),
         }
     }

coordinator/src/orderbook/db/orders.rs

@@ -66,6 +66,7 @@ impl From<OrderState> for OrderBookOrderState {
             OrderState::Taken => OrderBookOrderState::Taken,
             OrderState::Failed => OrderBookOrderState::Failed,
             OrderState::Expired => OrderBookOrderState::Expired,
+            OrderState::Deleted => OrderBookOrderState::Deleted,
         }
     }
 }
@@ -78,6 +79,7 @@ impl From<OrderBookOrderState> for OrderState {
             OrderBookOrderState::Taken => OrderState::Taken,
             OrderBookOrderState::Failed => OrderState::Failed,
             OrderBookOrderState::Expired => OrderState::Expired,
+            OrderBookOrderState::Deleted => OrderState::Deleted,
         }
     }
 }
@@ -266,6 +268,11 @@ pub fn set_is_taken(
     }
 }
 
+/// Updates the order state to `Deleted`
+pub fn delete(conn: &mut PgConnection, id: Uuid) -> QueryResult<OrderbookOrder> {
+    set_order_state(conn, id, commons::OrderState::Deleted)
+}
+
 /// Returns the number of affected rows: 1.
 pub fn set_order_state(
     conn: &mut PgConnection,

coordinator/src/orderbook/routes.rs

@@ -154,6 +154,20 @@ pub async fn put_order(
     Ok(Json(order))
 }
 
+#[instrument(skip_all, err(Debug))]
+pub async fn delete_order(
+    Path(order_id): Path<Uuid>,
+    State(state): State<Arc<AppState>>,
+) -> Result<Json<Order>, AppError> {
+    let mut conn = get_db_connection(&state)?;
+    let order = orderbook::db::orders::delete(&mut conn, order_id)
+        .map_err(|e| AppError::InternalServerError(format!("Failed to delete order: {e:#}")))?;
+    let sender = state.tx_price_feed.clone();
+    update_pricefeed(Message::Update(order.clone()), sender);
+
+    Ok(Json(order))
+}
+
 pub async fn websocket_handler(
     ws: WebSocketUpgrade,
     State(state): State<Arc<AppState>>,

coordinator/src/routes.rs

@@ -26,6 +26,7 @@ use crate::message::NewUserMessage;
 use crate::message::OrderbookMessage;
 use crate::node::Node;
 use crate::notifications::Notification;
+use crate::orderbook::routes::delete_order;
 use crate::orderbook::routes::get_order;
 use crate::orderbook::routes::get_orders;
 use crate::orderbook::routes::post_order;
@@ -162,7 +163,7 @@ pub fn router(
         .route("/api/orderbook/orders", get(get_orders).post(post_order))
         .route(
             "/api/orderbook/orders/:order_id",
-            get(get_order).put(put_order),
+            get(get_order).put(put_order).delete(delete_order),
         )
         .route("/api/orderbook/websocket", get(websocket_handler))
         .route("/api/trade", post(post_trade))

crates/commons/src/order.rs

@@ -111,6 +111,7 @@ pub enum OrderState {
     Taken,
     Failed,
     Expired,
+    Deleted,
 }
 
 #[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]