Merge pull request #2317 from get10101/fix/confirmation-calculation

Compute confirmations correctly
get10101 · Mar 25, 2024 · efcdc35 · efcdc35
2 parents 55753a3 + 8b7564d
commit efcdc35
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/crates/ln-dlc-node/src/on_chain_wallet.rs b/crates/ln-dlc-node/src/on_chain_wallet.rs
@@ -125,10 +125,8 @@ impl<D> OnChainWallet<D> {
 
         let tip = self.get_tip();
         let n_confirmations = match tip.checked_sub(confirmation_height) {
-            Some(diff) => NonZeroU32::new(diff).unwrap_or({
-                // Being included in a block counts as a confirmation!
-                NonZeroU32::new(1).expect("non-zero value")
-            }),
+            // Being included in a block counts as a confirmation!
+            Some(diff) => NonZeroU32::new(diff + 1).expect("non-zero"),
             None => {
                 // The transaction shouldn't be ahead of the tip!
                 debug_assert!(false);