feat: Set invoice state to canceled instead of failed

We can't really know if the invoice failed or got canceled. I think canceled is the better state name though.

coordinator/migrations/2024-05-31-144618_add-canceled-invoice-state/down.sql

@@ -0,0 +1,5 @@
+-- Postgres does not allow removing enum type values. One can only re-create an enum type with fewer values and replace the references.
+-- However, there is no proper way to replace the values to be removed where they are used (i.e. referenced in `hodl_invoice` table)
+-- We opt to NOT remove enum values that were added at a later point.
+
+select 1;

coordinator/migrations/2024-05-31-144618_add-canceled-invoice-state/up.sql

@@ -0,0 +1 @@
+ALTER TYPE "InvoiceState_Type" ADD VALUE IF NOT EXISTS 'Canceled';

coordinator/src/db/custom_types.rs

@@ -275,6 +275,7 @@ impl ToSql<InvoiceStateType, Pg> for InvoiceState {
             InvoiceState::Accepted => out.write_all(b"Accepted")?,
             InvoiceState::Settled => out.write_all(b"Settled")?,
             InvoiceState::Failed => out.write_all(b"Failed")?,
+            InvoiceState::Canceled => out.write_all(b"Canceled")?,
         }
         Ok(IsNull::No)
     }
@@ -287,6 +288,7 @@ impl FromSql<InvoiceStateType, Pg> for InvoiceState {
             b"Accepted" => Ok(InvoiceState::Accepted),
             b"Settled" => Ok(InvoiceState::Settled),
             b"Failed" => Ok(InvoiceState::Failed),
+            b"Canceled" => Ok(InvoiceState::Canceled),
             _ => Err("Unrecognized enum variant".into()),
         }
     }

coordinator/src/db/hodl_invoice.rs

@@ -23,6 +23,7 @@ pub enum InvoiceState {
     Accepted,
     Settled,
     Failed,
+    Canceled,
 }
 
 impl QueryId for InvoiceStateType {
@@ -95,15 +96,15 @@ pub fn update_hodl_invoice_to_settled(
         .get_result(conn)
 }
 
-pub fn update_hodl_invoice_to_failed_by_r_hash(
+pub fn update_hodl_invoice_to_canceled(
     conn: &mut PgConnection,
     r_hash: String,
 ) -> QueryResult<usize> {
     diesel::update(hodl_invoices::table)
         .filter(hodl_invoices::r_hash.eq(r_hash))
         .set((
             hodl_invoices::updated_at.eq(OffsetDateTime::now_utc()),
-            hodl_invoices::invoice_state.eq(InvoiceState::Failed),
+            hodl_invoices::invoice_state.eq(InvoiceState::Canceled),
         ))
         .execute(conn)
 }

coordinator/src/node/invoice.rs

@@ -41,7 +41,7 @@ pub fn spawn_invoice_watch(
                             let r_hash = r_hash.clone();
                             move || {
                                 let mut conn = pool.get()?;
-                                db::hodl_invoice::update_hodl_invoice_to_failed_by_r_hash(
+                                db::hodl_invoice::update_hodl_invoice_to_canceled(
                                     &mut conn, r_hash,
                                 )?;
                                 anyhow::Ok(())