-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only fund when faucet balance drops below 10 000 000 sats #1003
Conversation
This speeds up development a little bit. The balance is retrieved by `curl`ing the channel balance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ideal this change: sometimes we will need to fund an already funded node again.
Maybe a new For context, the problem I am trying to solve is the fund process being run every time I run |
I never use this command 🙈 I like to keep an eye on what is happening and call each step separately. I'm fine with a different function or an extra arg I can pass in to force funding again. |
Fair enough! Do you have any preference as to a new command or arg? |
Eitherway is fine with me :) |
Added arguments -f & --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This speeds up development a little bit. The balance is retrieved by
curl
ing the channel balance.I left this out of the
fund-regtest
recipe since it seems to be a manually invoked recipe and not an automated prerequiste, hence it is not really needed.