Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fund when faucet balance drops below 10 000 000 sats #1003

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

Restioson
Copy link
Contributor

This speeds up development a little bit. The balance is retrieved by curling the channel balance.

I left this out of the fund-regtest recipe since it seems to be a manually invoked recipe and not an automated prerequiste, hence it is not really needed.

This speeds up development a little bit. The balance is retrieved by `curl`ing the channel balance
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal this change: sometimes we will need to fund an already funded node again.

@Restioson
Copy link
Contributor Author

Not ideal this change: sometimes we will need to fund an already funded node again.

Maybe a new force-fund command for that? Or, a new autofund command and use that for the prerequisite in all etc.

For context, the problem I am trying to solve is the fund process being run every time I run just all to start the app for debugging

@bonomat
Copy link
Contributor

bonomat commented Jul 25, 2023

Not ideal this change: sometimes we will need to fund an already funded node again.

Maybe a new force-fund command for that? Or, a new autofund command and use that for the prerequisite in all etc.

For context, the problem I am trying to solve is the fund process being run every time I run just all to start the app for debugging

I never use this command 🙈 I like to keep an eye on what is happening and call each step separately.
That way I also don't have to call all repeatatly as I most of the time either work on the app or on the coordinator but not on all.

I'm fine with a different function or an extra arg I can pass in to force funding again.

@Restioson
Copy link
Contributor Author

Fair enough! Do you have any preference as to a new command or arg?

@bonomat
Copy link
Contributor

bonomat commented Jul 25, 2023

Fair enough! Do you have any preference as to a new command or arg?

Eitherway is fine with me :)

@Restioson
Copy link
Contributor Author

Added arguments -f & --force

@Restioson Restioson requested a review from bonomat July 28, 2023 08:13
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Restioson Restioson added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit cced67a Jul 28, 2023
7 checks passed
@Restioson Restioson deleted the fund-only-when-necessary branch July 28, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants