Reconnect to BitMex if the websocket disconnects #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering why this piece of code would not already work to reconnect to bitmex? I just found this now. |
|
Ah, even prolonged physical disconnection of my PC's ethernet cable (5min) does not provoke this code to execute. It seems like there is no timeout in place from the client side at all, and sends do not fail either, because we throw away the result of the ping. The way I see it, we can either propagate the error upward, add a timeout, or both. EDIT: it looks like the send doesn't fail... strange. I guess we need to have a timeout then. |
Restioson
force-pushed
the
reconnect-to-bitmex
branch
from
7f055d1
to
5b19d8d
Compare
This is to prevent the websocket from getting stuck if disconnected, as pings will still return Ok(()) even if the link layer fails
Restioson
force-pushed
the
reconnect-to-bitmex
branch
from
5b19d8d
to
fc98e5f
Compare
bonomat
approved these changes
Jul 27, 2023
|
bors r+ |
|
bors r- |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2023
1014: Reconnect to BitMex if the websocket disconnects r=bonomat a=Restioson Adds a timeout to the websocket to bitmex in order to provoke a reconnect if the websocket becomes unresponsive. Fixes #919. Co-authored-by: Restioson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a timeout to the websocket to bitmex in order to provoke a reconnect if the websocket becomes unresponsive. Fixes #919.