Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting RUST_LOG to any value in just all #1016

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Restioson
Copy link
Contributor

While investigating #1004 I discovered that you can't run RUST_LOG=warn just all since that makes FRB codegen panic. I just overrode RUST_LOG to either debug or info depending on its actual value for the FRB codegen calls.

Copy link
Contributor

@klochowicz klochowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but maybe we could open a ticket against this totally unreasonable behaviour on FRB as well? 😅

thanks for sorting this out!

@klochowicz klochowicz added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit 1f52d2a Aug 1, 2023
7 checks passed
@klochowicz klochowicz deleted the allow-setting-rust-log branch August 1, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants