fix: no_route found in local dev setup #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with this we can manually trigger a node announcement if needed
holzeis
approved these changes
Jul 27, 2023
| @@ -7,6 +7,7 @@ use crate::ln::EventHandler; | |||
| use crate::ln::TracingLogger; | |||
There was a problem hiding this comment.
🙃 the commit message actually says something different than what the change entails 😅
"move helper function out of mod" would be correct 🙃
There was a problem hiding this comment.
in-out, same same but different
We need to wait until the node announcement was processed correctly by lnd. This can be checked if lnd is aware of the coordinator's `node_alias`
bonomat
force-pushed
the
chore/manual-node-announcement
branch
from
6c77a83
to
3583062
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to wait until the node announcement was processed correctly by lnd. This can be checked if lnd is aware of the coordinator's
node_alias.In the below patches we change the node announcement to 1/hour and allow triggering it manually using a http enpoint. With this I was so to always get into a working setup :)
fixes #764