Run rustfmt with nightly
#1049
Merged
Run rustfmt with nightly
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must do this if we want `dprint` to respect some of the unstable options we have configured in our `rustfmt.toml`. This is what we get if we run `cargo fmt` (as opposed to `cargo +nightly fmt`): ``` Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel. Warning: can't set `comment_width = 100`, unstable features are only available in nightly channel. Warning: can't set `imports_granularity = Item`, unstable features are only available in nightly channel. Warning: can't set `group_imports = One`, unstable features are only available in nightly channel. ``` After running `dprint fmt` with the new configuration we can see that the autoformatter consistently applies `group_imports = One` to our codebase.
luckysori
force-pushed
the
fix/dprint-rustfmt-nightly
branch
from
5e1d14b
to
c38dd57
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must do this if we want
dprintto respect some of the unstable options we have configured in ourrustfmt.toml. This is what we get if we runcargo fmt(as opposed tocargo +nightly fmt):After running
dprint fmtwith the new configuration we can see that the autoformatter consistently appliesgroup_imports = Oneto our codebase.