Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to publish transaction spending no LDK spendable outputs #1053

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Do not attempt to publish transaction spending no LDK spendable outputs #1053

merged 1 commit into from
Aug 2, 2023

Conversation

luckysori
Copy link
Contributor

Otherwise we see errors in the logs, because transactions spending no UTXOs are obviously invalid!

@luckysori
fix(ln-dlc-node): Do not attempt to spend 0 spendable outputs
6d1f097 
Otherwise we see errors in the logs, because transactions spending no
UTXOs are obviously invalid!
@luckysori luckysori self-assigned this Aug 2, 2023
holzeis
holzeis approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 👍

@luckysori luckysori added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit 7380394 Aug 2, 2023
7 checks passed
@luckysori luckysori deleted the fix/no-spend-0-spendable-outputs branch August 2, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonomat bonomat bonomat approved these changes

@holzeis holzeis holzeis approved these changes

@klochowicz klochowicz Awaiting requested review from klochowicz

Assignees

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luckysori @bonomat @holzeis