Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add beta disclaimer #1573

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat: Add beta disclaimer #1573

merged 1 commit into from
Nov 15, 2023

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Nov 14, 2023

  • The wallet is initialized once the toggles are confirmed on the welcome screen. (Preventing the user to skip over the disclaimer by restarting the app and uses the loading screen to show that the app is doing something)
  • Add a custom switch component. Primarily copied from https://stackoverflow.com/a/60090216/8643355
  • The email is now optional.
iPhone SE Screenshot

Simulator Screenshot - iPhone SE (3rd generation) - 2023-11-14 at 16 22 58

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-11-14.at.16.29.43.mp4

@holzeis holzeis self-assigned this Nov 14, 2023
@holzeis holzeis linked an issue Nov 14, 2023 that may be closed by this pull request
@holzeis holzeis changed the title feat: Add backup and restore feat: Add beta disclaimer Nov 14, 2023
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I mostly focused on how the video looks.

mobile/lib/features/welcome/welcome_screen.dart Outdated Show resolved Hide resolved
mobile/lib/features/welcome/welcome_screen.dart Outdated Show resolved Hide resolved
mobile/lib/features/welcome/welcome_screen.dart Outdated Show resolved Hide resolved
@holzeis holzeis force-pushed the feat/backup-app branch 3 times, most recently from 139d91f to 4016071 Compare November 15, 2023 10:58
- The wallet is initialized once the toggles are confirmed on the welcome screen. (This fixes a bug, where the user could have restarted the app to skip over the disclaimer and uses the loading screen to show that the app is doing something)

- Add a custom switch component. Primarily copied from https://stackoverflow.com/a/60090216/8643355
Base automatically changed from feat/backup-app to main November 15, 2023 12:41
@holzeis holzeis added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 50e4b4e Nov 15, 2023
9 checks passed
@holzeis holzeis deleted the feat/public-beta-disclaimer branch November 15, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a disclaimer to the app
2 participants