fix: Accept collaborative close offer from coordinator #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzeis
force-pushed
the
feat/dlc-channel-recovery-on-restart
branch
2 times, most recently
from
a724da4
to
14a2169
Compare
holzeis
force-pushed
the
fix/accept-collab-close-offer-from-coordinator
branch
from
4b38c1a
to
22e9c49
Compare
bonomat
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Afaik @luckysori also added this in one of his branches.
Let's wait for his approval before merging please.
I don't think I added this logic :D |
luckysori
approved these changes
Jan 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
…from-coordinator fix: Accept collaborative close offer from coordinator
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
holzeis
force-pushed
the
fix/accept-collab-close-offer-from-coordinator
branch
from
22e9c49
to
49aaf73
Compare
I noticed that both parties can trigger a collaborative dlc channel close, but only the coordinator had the logic implemented to also accept it. This will allow the app also to accept a collab close offer from the coordinator.
holzeis
force-pushed
the
fix/accept-collab-close-offer-from-coordinator
branch
from
49aaf73
to
7531c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that both parties can trigger a collaborative dlc channel close, but only the coordinator had the logic implemented to also accept it. This will allow the app also to accept a collab close offer from the coordinator.