chore: Publish recover dlc background task #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the app will show a dialog that the dlc protocol got interrupted and is in the process of recovery.
This is not needed anymore due to the new recovery logic.
holzeis
deleted the
chore/show-recovery-dialog-on-interrupted-protocol
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a panic before accepting the
SettleOfferto demonstrate how the recovery would look like.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-16.at.22.08.03.mp4
Note, there is still a bug left in which sometimes the dialog would not be shown, due to the shellNavigationKey.currentContext being empty. That was definitely already an issue before. Unfortunately, I couldn't find a fix for that in this PR.