Another fix for the e2e tests #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default this is set to 2MB, according to the docs[1]. We need larger bodies than before (even in the e2e test!), because we added lots of CET adaptor signatures to the database recently[2]. I also played around with nginx's `client_max_body_size`, but that's actually irrelevant since we don't use nginx as a reverse proxy for the coordinator in the e2e tests. Related to #1719. [1]: https://docs.rs/axum/latest/axum/extract/struct.DefaultBodyLimit.html#method.disable. [2]: #1817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1719, although we need to think about #1719 (comment) moving forward.
With this we should be able to re-enable the e2e tests as a required job to merge PRs.
I removed the
makertest because it's not relevant anymore and I reintroduced therestore_from_backuptest after fixing a bug.