Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure cors for webapp #1865

Merged
merged 1 commit into from
Jan 22, 2024
Merged

chore: configure cors for webapp #1865

merged 1 commit into from
Jan 22, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Jan 22, 2024

This allows us to send request from the webapp while in dev mode

@@ -116,6 +117,7 @@ fn using_serve_dir(subscribers: Arc<AppSubscribers>) -> Router {
},
),
)
.layer(CorsLayer::permissive())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 We should probably only add this when network is set to "regtest"

@holzeis
Copy link
Contributor

holzeis commented Jan 22, 2024

Thanks, that will be very useful! 👍

@bonomat bonomat added this pull request to the merge queue Jan 22, 2024
Merged via the queue into get10101:main with commit 0b7a1fe Jan 22, 2024
9 checks passed
@bonomat bonomat deleted the feat/cors branch January 22, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants