Map SignedChannelState to ChannelStatus correctly
#1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Been there, done that.
I think it's correct to assume that a `Established` channel is one that has a position. But a `RenewFinalized` channel is still pending completion of the renew protocol and will eventually transition back to `Established`. This behaviour can be seen in our `can_open_and_settle_offchain` test in the `ln-dlc-node` crate.
holzeis
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's correct to assume that a
Establishedchannel is one that has a position. But aRenewFinalizedchannel is still pendingcompletion of the renew protocol and will eventually transition back to
Established.This behaviour can be seen in our
can_open_and_settle_offchaintest in theln-dlc-nodecrate.