Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload android apk #1943

Merged
merged 1 commit into from
Feb 3, 2024
Merged

feat: upload android apk #1943

merged 1 commit into from
Feb 3, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Feb 1, 2024

Untested because I didn't want to play around with all the env variables on my fork :/

This will upload the APKs as artifact to the GitHub action. If the APKs work, we can use https://github.com/softprops/action-gh-release (or similar) to upload the APKs to our release.

Step towards #1642

@bonomat bonomat changed the title chore: print latest height after sync feat: upload android apk Feb 1, 2024
Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bonomat
Copy link
Contributor Author

bonomat commented Feb 2, 2024

Local APK worked on my phone.

What do you think of having a Latest release on GitHub which is constantly updated whenever we merge something into main?

@bonomat bonomat added this pull request to the merge queue Feb 2, 2024
@bonomat bonomat mentioned this pull request Feb 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2024
@bonomat bonomat added this pull request to the merge queue Feb 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2024
@bonomat
Copy link
Contributor Author

bonomat commented Feb 3, 2024

Merging this without CI as there were no code changes.

@bonomat bonomat merged commit a5ac6a3 into main Feb 3, 2024
4 checks passed
@bonomat bonomat deleted the feat/upload-apk branch February 3, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants