Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Propose the settled amount when collab closing a channel #2005

Merged
merged 3 commits into from
Feb 10, 2024
Merged

fix: Propose the settled amount when collab closing a channel #2005

merged 3 commits into from
Feb 10, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Feb 10, 2024

No description provided.

@holzeis holzeis self-assigned this Feb 10, 2024
@holzeis holzeis linked an issue Feb 10, 2024 that may be closed by this pull request
Collab closing a channel proposes the incorrect amount to close the channel #2004
Closed
@bonomat bonomat force-pushed the fix/propose-correct-amount-in-collab-close branch from e77eb77 to ca06397 Compare February 10, 2024 14:48
bonomat
bonomat approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @holzeis .

I've added a test which asserts the balance after closing and pushed this test before the fix to show that it first fails and then works.

Note: this is now an issue, but that's not critical

@bonomat bonomat force-pushed the fix/propose-correct-amount-in-collab-close branch from ca06397 to 4db9e87 Compare February 10, 2024 15:04
@bonomat bonomat added this pull request to the merge queue Feb 10, 2024
Merged via the queue into main with commit 4991816 Feb 10, 2024
10 of 20 checks passed
@bonomat bonomat deleted the fix/propose-correct-amount-in-collab-close branch February 10, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonomat bonomat bonomat approved these changes

@luckysori luckysori Awaiting requested review from luckysori

Assignees

@holzeis holzeis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collab closing a channel proposes the incorrect amount to close the channel
2 participants
@holzeis @bonomat