Add Firebase Crashlytics support #2069

luckysori · 2024-02-20T07:04:24Z

Could not test because simulator is not working locally.

Motivated by issues like this one: https://github.com/get10101/meta/issues/351#issuecomment-1953562415.

holzeis

LGTM 👍

bonomat · 2024-02-21T07:37:40Z

mobile/android/app/google-services.json

@@ -0,0 +1,46 @@
+{


🛠️ Afaik we are using a dynamic approach for this google-service.json because we need to support our dev env and mainnet.
I'm happy to take this over and test locally..

bonomat

see this: https://github.com/get10101/10101/pull/2069/files#r1497029468

Firebase is not just about push notifications.

So that we don't have to rely on TestFlight for crash reports.

bonomat · 2024-02-21T15:30:58Z

I've troubles running this PR on a simulator. My understanding is that for the crash report to work it needs to upload some sym-files which seems to get stuck.

I have it in Compiling, linking and signing. since ~20 minutes without any progress. :/

luckysori · 2024-02-22T02:27:55Z

I've troubles running this PR on a simulator. My understanding is that for the crash report to work it needs to upload some sym-files which seems to get stuck.

I have it in Compiling, linking and signing. since ~20 minutes without any progress. :/

Thanks for giving it a go. I'll see if I can find time to configure my emulator setup today or tomorrow.

luckysori · 2024-02-27T07:29:06Z

@holzeis: please try just run on this PR.

Additionally, you can see if an exception shows up on Firebase.

holzeis · 2024-02-27T15:32:41Z

@holzeis: please try just run on this PR.

Additionally, you can see if an exception shows up on Firebase.

just run fails on my machine.

$ just run
Launching lib/main.dart on iPhone 15 Pro in debug mode...
Running pod install...                                             637ms
CocoaPods' output:
↳
      Preparing

    Analyzing dependencies

    Inspecting targets to integrate
      Using `ARCHS` setting to build architectures of target `Pods-Runner`: (``)

    Finding Podfile changes
      A firebase_analytics
      A firebase_crashlytics
      - Flutter
      - firebase_core
      - firebase_messaging
      - flutter_local_notifications
      - flutter_native_splash
      - package_info_plus
      - path_provider_foundation
      - qr_code_scanner
      - share_plus
      - shared_preferences_foundation
      - social_share
      - url_launcher_ios

    Fetching external sources
    -> Fetching podspec for `Flutter` from `Flutter`
    -> Fetching podspec for `firebase_analytics` from `.symlinks/plugins/firebase_analytics/ios`
    firebase_analytics: Using Firebase SDK version '10.18.0' defined in 'firebase_core'
    -> Fetching podspec for `firebase_core` from `.symlinks/plugins/firebase_core/ios`
    firebase_core: Using Firebase SDK version '10.18.0' defined in 'firebase_core'
    -> Fetching podspec for `firebase_crashlytics` from `.symlinks/plugins/firebase_crashlytics/ios`
    Run script to upload symbols already exists.
    firebase_crashlytics: Using Firebase SDK version '10.18.0' defined in 'firebase_core'
    -> Fetching podspec for `firebase_messaging` from `.symlinks/plugins/firebase_messaging/ios`
    firebase_messaging: Using Firebase SDK version '10.18.0' defined in 'firebase_core'
    -> Fetching podspec for `flutter_local_notifications` from `.symlinks/plugins/flutter_local_notifications/ios`
    -> Fetching podspec for `flutter_native_splash` from `.symlinks/plugins/flutter_native_splash/ios`
    -> Fetching podspec for `package_info_plus` from `.symlinks/plugins/package_info_plus/ios`
    -> Fetching podspec for `path_provider_foundation` from `.symlinks/plugins/path_provider_foundation/darwin`
    -> Fetching podspec for `qr_code_scanner` from `.symlinks/plugins/qr_code_scanner/ios`
    -> Fetching podspec for `share_plus` from `.symlinks/plugins/share_plus/ios`
    -> Fetching podspec for `shared_preferences_foundation` from `.symlinks/plugins/shared_preferences_foundation/darwin`
    -> Fetching podspec for `social_share` from `.symlinks/plugins/social_share/ios`
    -> Fetching podspec for `url_launcher_ios` from `.symlinks/plugins/url_launcher_ios/ios`

    Resolving dependencies of `Podfile`
      CDN: trunk Relative path: CocoaPods-version.yml exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: all_pods_versions_0_3_5.txt exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: Specs/0/3/5/Firebase/10.17.0/Firebase.podspec.json exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: all_pods_versions_4_2_c.txt exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: Specs/4/2/c/FlutterMacOS/3.13.2/FlutterMacOS.podspec.json exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: all_pods_versions_0_2_a.txt exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: Specs/0/2/a/MTBBarcodeScanner/5.0.11/MTBBarcodeScanner.podspec.json exists! Returning local because checking is only performed in repo update
      CDN: trunk Relative path: Specs/0/3/5/Firebase/10.12.0/Firebase.podspec.json exists! Returning local because checking is only performed in repo update
    [!] CocoaPods could not find compatible versions for pod "Firebase/CoreOnly":
      In snapshot (Podfile.lock):
        Firebase/CoreOnly (= 10.12.0)

      In Podfile:
        firebase_core (from `.symlinks/plugins/firebase_core/ios`) was resolved to 2.24.2, which depends on
          Firebase/CoreOnly (= 10.18.0)

    Specs satisfying the `Firebase/CoreOnly (= 10.12.0), Firebase/CoreOnly (= 10.18.0)` dependency were found, but they required a higher minimum deployment target.

    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:317:in `raise_error_unless_state'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:299:in `block in unwind_for_conflict'
    <internal:kernel>:90:in `tap'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:297:in `unwind_for_conflict'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:257:in `process_topmost_state'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/molinillo-0.8.0/lib/molinillo/resolution.rb:182:in `resolve'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/molinillo-0.8.0/lib/molinillo/resolver.rb:43:in `resolve'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/resolver.rb:94:in `resolve'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer/analyzer.rb:1082:in `block in resolve_dependencies'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/user_interface.rb:64:in `section'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer/analyzer.rb:1080:in `resolve_dependencies'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer/analyzer.rb:125:in `analyze'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:422:in `analyze'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:244:in `block in resolve_dependencies'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/user_interface.rb:64:in `section'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:243:in `resolve_dependencies'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:162:in `install!'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/command/install.rb:52:in `run'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/claide-1.1.0/lib/claide/command.rb:334:in `run'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/lib/cocoapods/command.rb:52:in `run'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/gems/cocoapods-1.15.2/bin/pod:55:in `<top (required)>'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/bin/pod:25:in `load'
    /opt/homebrew/Cellar/cocoapods/1.15.2/libexec/bin/pod:25:in `<main>'

Error output from CocoaPods:
↳
    Ignoring digest-crc-0.6.5 because its extensions are not built. Try: gem pristine digest-crc --version 0.6.5
    Ignoring ffi-1.16.3 because its extensions are not built. Try: gem pristine ffi --version 1.16.3
    Ignoring ffi-1.15.5 because its extensions are not built. Try: gem pristine ffi --version 1.15.5
    Ignoring json-2.6.3 because its extensions are not built. Try: gem pristine json --version 2.6.3
    Ignoring unf_ext-0.0.8.2 because its extensions are not built. Try: gem pristine unf_ext --version 0.0.8.2

Error running pod install
Error launching application on iPhone 15 Pro.
error: Recipe `run` failed with exit code 1

bonomat · 2024-02-28T12:44:02Z

CocoaPods could not find compatible versions for pod "Firebase/CoreOnly":

What cocoapod version are you running?

I have

pod --version
1.15.2

holzeis · 2024-02-29T08:54:34Z

What cocoapod version are you running?

$ pod --version
1.15.2

bonomat · 2024-03-03T05:01:23Z

What cocoapod version are you running?
$ pod --version
1.15.2

Well, same version as I am on but different error 🤷‍♂️

bonomat · 2024-03-12T07:24:23Z

It's a shame that it doesn't work out of the box, but let's close it.

github-actions bot assigned luckysori Feb 20, 2024

luckysori requested review from holzeis and bonomat February 20, 2024 07:05

luckysori force-pushed the feat/firebase-crashlytics branch from 5ec5a84 to f93e73c Compare February 20, 2024 07:33

holzeis approved these changes Feb 20, 2024

View reviewed changes

bonomat reviewed Feb 21, 2024

View reviewed changes

bonomat requested changes Feb 21, 2024

View reviewed changes

luckysori added 4 commits February 21, 2024 11:14

chore(app): Rename notifications.dart to firebase.dart

3e78a9f

Firebase is not just about push notifications.

feat(app): Enable Firebase Crashlytics

6faa508

So that we don't have to rely on TestFlight for crash reports.

fix(justfile): Fix Electrs port for run-local-android recipe

75bb4fb

chore(ln-dlc-node): Add unit to tracing field name

806b602

bonomat force-pushed the feat/firebase-crashlytics branch from f93e73c to 806b602 Compare February 21, 2024 13:22

luckysori assigned holzeis Feb 27, 2024

holzeis removed their assignment Feb 29, 2024

bonomat closed this Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Firebase Crashlytics support #2069

Add Firebase Crashlytics support #2069

luckysori commented Feb 20, 2024 •

edited

Loading

holzeis left a comment

bonomat Feb 21, 2024

bonomat left a comment

bonomat commented Feb 21, 2024

luckysori commented Feb 22, 2024

luckysori commented Feb 27, 2024

holzeis commented Feb 27, 2024

bonomat commented Feb 28, 2024

holzeis commented Feb 29, 2024

bonomat commented Mar 3, 2024

bonomat commented Mar 12, 2024

Add Firebase Crashlytics support #2069

Add Firebase Crashlytics support #2069

Conversation

luckysori commented Feb 20, 2024 • edited Loading

holzeis left a comment

Choose a reason for hiding this comment

bonomat Feb 21, 2024

Choose a reason for hiding this comment

bonomat left a comment

Choose a reason for hiding this comment

bonomat commented Feb 21, 2024

luckysori commented Feb 22, 2024

luckysori commented Feb 27, 2024

holzeis commented Feb 27, 2024

bonomat commented Feb 28, 2024

holzeis commented Feb 29, 2024

bonomat commented Mar 3, 2024

bonomat commented Mar 12, 2024

luckysori commented Feb 20, 2024 •

edited

Loading