Webapp: Allow user to close/force-close channel #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serializing a simple vec<string> is error prone. Also, the frontend was erroring because the field seed was not initialized. With the future builder we temporarily show a loading indicator while retrieving the seed. Signed-off-by: Philipp Hoenisch <[email protected]>
casting null to a map errors, hence, we need to handle this case specifically. Signed-off-by: Philipp Hoenisch <[email protected]>
Signed-off-by: Philipp Hoenisch <[email protected]>
Signed-off-by: Philipp Hoenisch <[email protected]>
Signed-off-by: Philipp Hoenisch <[email protected]>
|
Minor findings:
|
I believe it should work. There is no reason why this shouldn't work as it's basically a CPFP
That should work. The refresh of the webinterface is a bit slow because the backend doesn't sync so fast. |
holzeis
approved these changes
Feb 20, 2024
Signed-off-by: Philipp Hoenisch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2061
Note: the error in the video is already fixed.
Untitled.mov